Skip to content

bpo-5038: http lib, seek to the beginning of mmap'ed file#11843

Closed
ghost wants to merge 4 commits into
masterfrom
unknown repository
Closed

bpo-5038: http lib, seek to the beginning of mmap'ed file#11843
ghost wants to merge 4 commits into
masterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 13, 2019

seek file pointer to the beginning of the file
for mmap'ed message bodies after the file has been fully read
by http client when sending requests, this ensures that
the file contents can be read in subsequent requests.

https://bugs.python.org/issue5038

seek file pointer to the beginning of the file
for mmap'ed message bodies after the file has been fully read
by http client when sending requests, this ensures that
the file contents can be read in subsequent requests.
@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 15, 2019

I'm quite new here, does this need a testcase? CLA should be signed by now afaik.

@ghost ghost closed this Feb 15, 2019
@ghost ghost reopened this Feb 15, 2019
@ghost ghost closed this Feb 17, 2019
@ghost ghost deleted the fix-issue-5038 branch February 17, 2019 08:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants